refactor: MemberImage 컴포넌트 추가 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results2 tests 2 ✅ 7s ⏱️ Results for commit b5a50bb. ♻️ This comment has been updated with latest results. |
Leejin-Yang
reviewed
Jan 9, 2024
Comment on lines
16
to
20
| const [imageSrc, setImageSrc] = useState(src); | ||
|
|
||
| const handleImageError = () => { | ||
| setImageSrc(DefaultMemberImage); | ||
| }; |
There was a problem hiding this comment.
상태에 경로를 담는것 보다 boolean으로 다루면 어떨까요??
There was a problem hiding this comment.
밑에서 그럼
{isError ? <DefaultMemberImage/> : <MemberImage /> }이런식으로 처리하라는 말씀이신가요?!
There was a problem hiding this comment.
아래 src 속성에서 처리하면 좋아보여요.!
불린 속성에 따라 src가 변하게?!
Leejin-Yang
approved these changes
Jan 9, 2024
Comment on lines
+16
to
+31
| const [isError, setIsError] = useState(false); | ||
|
|
||
| const handleImageError = () => { | ||
| setIsError(true); | ||
| }; | ||
|
|
||
| return ( | ||
| <StyledMemberImage | ||
| src={isError ? DefaultMemberImage : src} | ||
| alt={alt} | ||
| width={width} | ||
| height={height} | ||
| css={css} | ||
| onError={handleImageError} | ||
| /> | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
너무 오랜만에 코드 쳐서 잘 모르겠어요..
🎸 기타
⏰ 일정