Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 프로필 default 이미지 설정 #159

Merged
merged 5 commits into from
Jun 28, 2024
Merged

fix: 프로필 default 이미지 설정 #159

merged 5 commits into from
Jun 28, 2024

Conversation

hae-on
Copy link
Contributor

@hae-on hae-on commented Jun 26, 2024

Issue

✨ 구현한 기능

  • 리뷰아이템 프로필 이미지 요소 변경 (img -> MemberImage)
  • null 예외처리 (product detail image, product overview image)
  • 리뷰 랭킹 mock data 프로필 관련 빠진 부분 추가
스크린샷 2024-06-26 오후 1 36 06 스크린샷 2024-06-26 오후 1 56 44 스크린샷 2024-06-26 오후 2 27 43

📢 논의하고 싶은 내용

x

🎸 기타

x

⏰ 일정

  • 추정 시간 : 20분
  • 걸린 시간 : 20분

@hae-on hae-on requested review from xodms0309 and Leejin-Yang June 26, 2024 05:29
@hae-on hae-on self-assigned this Jun 26, 2024
Copy link

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-fomewgfptd.chromatic.com/

Copy link
Contributor

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 이거 진짜 필요했는데 👍

@hae-on hae-on merged commit 3e6b7e8 into feat/v2 Jun 28, 2024
2 of 3 checks passed
@hae-on hae-on deleted the fix/issue-154 branch June 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 디폴트 이미지 설정
2 participants