refactor: RecommendList 컴포넌트 리팩토링 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-vtqrmzohfy.chromatic.com/ |
hae-on
approved these changes
Apr 7, 2024
Leejin-Yang
approved these changes
Apr 7, 2024
Comment on lines
+22
to
+24
| <Text as="span" weight="semiBold"> | ||
| {fragment} | ||
| </Text> |
There was a problem hiding this comment.
이렇게 하면 <span>아아</span><mark>이이</mark><span>오오</span> 으로 되는건가요? 정규식을 잘 몰라서
There was a problem hiding this comment.
이거 황펭이 구현했던거자나요
댓글 내용이 맞습니당
|
@hae-on 넹 근데 이거 자동완성은 백엔드의 영역이라서..! 추가되려면 백엔드와 논의가 필요해보입니다 |
|
바로 머지하시죠~~ |
|
너무 기대가 됩니다 얼른 배포해주세요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
⏰ 일정