Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Heading 컴포넌트 추가 #87

Merged
merged 7 commits into from
Jul 5, 2024
Merged

feat: Heading 컴포넌트 추가 #87

merged 7 commits into from
Jul 5, 2024

Conversation

xodms0309
Copy link
Member

Issue

✨ 구현한 기능

  • Heading 컴포넌트를 추가하고 Typography라는 폴더를 만들어 아래에 Heading과 Text를 추가했습니다.

📢 논의하고 싶은 내용

  • x

🎸 기타

  • Heading이 딱히 크기별로 나눠진게 아니라서 그냥 Text 컴포넌트와 마찬가지로 외부에서 저희 디자인시스템의 크기를 줄 수 있도록 했습니다.

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 30분

@xodms0309 xodms0309 requested review from Leejin-Yang and hae-on April 14, 2024 18:19
@xodms0309 xodms0309 self-assigned this Apr 14, 2024
Copy link

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-itmlhbwopk.chromatic.com/

Copy link
Contributor

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왕 필요했는데~~~
잘 만들었네용~~~ 굿 😎

Copy link
Contributor

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~👍

@@ -22,6 +22,7 @@ export const text = recipe({
caption1: { fontSize: '1.4rem' },
body: { fontSize: '1.6rem' },
headline: { fontSize: '1.8rem' },
display1: { fontSize: '2.2rem' },
},
weight: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기에 bold도 추가해주세요~~
700으로 하면 될 듯?!

Copy link

github-actions bot commented Jul 5, 2024

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-wfpngxrfnt.chromatic.com/

@xodms0309 xodms0309 merged commit 2c58e96 into feat/v2 Jul 5, 2024
2 of 3 checks passed
@xodms0309 xodms0309 deleted the feat/issue-86 branch July 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heading 컴포넌트 추가
3 participants