feat: 상품 리뷰 작성 구현 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-tnsdjsaaum.chromatic.com/ |
hae-on
reviewed
Apr 18, 2024
src/components/Common/index.ts
Outdated
| @@ -25,3 +25,4 @@ export { default as PageHeader } from './PageHeader/PageHeader'; | |||
| export { default as Badge } from './Badge/Badge'; | |||
| export { default as WriteButton } from './WriteButton/WriteButton'; | |||
| export { default as Text } from './Text/Text'; | |||
| export { default as TopBar } from './TopBar/TopBar'; | |||
Comment on lines
+38
to
+44
| export const register = style({ | ||
| selectors: { | ||
| 'button:disabled > &': { | ||
| color: vars.colors.text.disabled, | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
@Creative-Lee 아니 어떻게 들어왔지..?ㅋㅋㅋㅋㅋㅋㅋ 맞아여
There was a problem hiding this comment.
피그마 시안에 없어서 삭제했슴다.!
src/contexts/ReviewFormContext.tsx
Outdated
Comment on lines
21
to
25
| interface Value { | ||
| isValid: boolean; | ||
| reviewFormValue: ReviewFormValue; | ||
| } | ||
|
|
There was a problem hiding this comment.
얘 이름이 Value인게 state가 reviewFormValue여서 그런거죠? 아예 state 이름을 formValue 같은 걸로 바꾸고, 얘를 ReivewFormAction이랑 통일감 있게 ReivewFormValue로 바꿔버리면 안되나??
|
@hae-on @xodms0309 |
|
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-shtfxtcvii.chromatic.com/ |
|
좋네요 LGTM~~~ |
|
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-ljdfxlfbng.chromatic.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
⏰ 일정