Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 꿀조합 검색 디자인 변경점 적용 #91

Merged
merged 13 commits into from
Apr 19, 2024
Merged

Conversation

xodms0309
Copy link
Member

@xodms0309 xodms0309 commented Apr 18, 2024

Issue

✨ 구현한 기능

스크린샷 2024-04-18 오후 5 07 52 스크린샷 2024-04-18 오후 5 09 31
  • 전체보기 버튼을 만들었습니다.
  • 꿀조합 검색 목록 페이지도 만들었습니다.
  • 해온이 만든 RecipeItem 컴포넌트로 교체했습니다

📢 논의하고 싶은 내용

  • Skeleton이 이상하게 로딩되는데 한 번 손봐야 할 듯 싶어요

🎸 기타

  • RecipeItem에서 링크이동이 안되길래 앞에 PATH.RECIPE 붙였습니다

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 1

@xodms0309 xodms0309 requested review from Leejin-Yang and hae-on April 18, 2024 15:09
@xodms0309 xodms0309 self-assigned this Apr 18, 2024
Copy link

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-acnztevthp.chromatic.com/

@@ -26,24 +25,15 @@ const RecipeSearchResultList = ({ searchQuery }: RecipeSearchResultListProps) =>

return (
<>
<RecipeSearchResultListContainer>
<PageHeader title={`'${searchQuery}'이/가 포함된 꿀조합`} hasBackLink />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 TopBar랑 디자인 다른가용??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 교체 가능

Copy link

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-wnfqgmovkp.chromatic.com/

Copy link
Contributor

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요 LGTM~👍

Comment on lines 37 to 44
<Link to={`${PATH.SEARCH}/recipes?query=${searchQuery}`} className={linkWrapper}>
<div className={showMore}>
<SvgIcon variant="arrowRight" stroke={vars.colors.gray5} />
</div>
<Text size="caption2" weight="semiBold" color="info">
전체보기
</Text>
</Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저 이거 만든거 있는데 합쳐주기 가능합니까.?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옹 이거 뭐죠?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체보기! 상품 상세 꿀조합 리스트에도 있슴다

Copy link

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-jfuvimwsjw.chromatic.com/

@xodms0309 xodms0309 merged commit f751e9e into feat/v2 Apr 19, 2024
2 of 3 checks passed
@xodms0309 xodms0309 deleted the feat/issue-80 branch April 19, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

꿀조합 검색 디자인 변경점 적용
3 participants