Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs have Home icon added to top level #518

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

atomworks
Copy link
Collaborator

This simply adds the home icon to the top level of the breadcrumb. It is set to on by default as the top level is usually intended to be the home reference but this can be optionally switched off if the project chooses to treat this differently. This is done with the showHomeIcon?: boolean prop.

At the moment no projects are known to be using this feature so this change isn't deemed to be breaking or disruptive. The first project this has been requested for will require this icon, though it is not critical.

New home icon can be seen here:
image

@atomworks atomworks requested a review from isacoder November 26, 2024 04:02
Copy link
Collaborator

@isacoder isacoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks for this update.

@isacoder isacoder merged commit 9cdd322 into main Nov 27, 2024
1 check passed
@isacoder isacoder deleted the feature/home-icon-for-breadcrumbs branch November 27, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants