Skip to content

Commit

Permalink
BUG FIX: Use of future.seed = TRUE could result in an error `!any(s…
Browse files Browse the repository at this point in the history
…eed_next != seed) is not TRUE` [#122]
  • Loading branch information
HenrikBengtsson committed Oct 27, 2024
1 parent 60e2a45 commit e7ce24c
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 14 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: future.apply
Version: 1.11.2-9001
Version: 1.11.2-9002
Title: Apply Function to Elements in Parallel using Futures
Depends:
R (>= 3.2.0),
Expand Down
5 changes: 4 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Version (development version)

* ...
## Bug Fixes

* Use of `future.seed = TRUE` could result in an error
`!any(seed_next != seed) is not TRUE` in rare cases.


# Version 1.11.2 [2024-03-27]
Expand Down
5 changes: 4 additions & 1 deletion R/rng_utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ set_random_seed <- function(seed) {
next_random_seed <- function(seed = get_random_seed()) {
sample.int(n = 1L, size = 1L, replace = FALSE)
seed_next <- get_random_seed()
stop_if_not(!any(seed_next != seed))

## Assert RNG state changed
stop_if_not(identical(seed_next, seed))

invisible(seed_next)
}

Expand Down
14 changes: 7 additions & 7 deletions pkgdown/_pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,20 @@ navbar:
pkgs:
text: Packages
menu:
- text: doFuture
- text: doFuture (map-reduce)
href: https://doFuture.futureverse.org
- text: furrr
- text: furrr (map-reduce)
href: https://furrr.futureverse.org
- text: future
href: https://future.futureverse.org
- text: future.apply
- text: future.apply (map-reduce)
href: https://future.apply.futureverse.org
- text: future.batchtools
- text: future.batchtools (backend)
href: https://future.batchtools.futureverse.org
- text: future.callr
- text: future.callr (backend)
href: https://future.callr.futureverse.org
- text: future.mirai (backend)
href: https://future.mirai.futureverse.org
- text: future.tests
href: https://future.tests.futureverse.org
- text: globals
Expand All @@ -45,8 +47,6 @@ navbar:
href: https://BiocParallel.FutureParam.futureverse.org
- text: future.tools (experimental)
href: https://future.tools.futureverse.org
- text: future.mirai (experimental)
href: https://future.mirai.futureverse.org
- text: future.mapreduce (experimental)
href: https://future.mapreduce.futureverse.org
- text: marshal (experimental)
Expand Down
10 changes: 6 additions & 4 deletions pkgdown/_pkgdown.yml.rsp
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<%
pkgs <- c("globals", "listenv", "parallelly", "future", "future.apply", "furrr", "future.tests", "future.callr", "future.batchtools", "doFuture", "progressr")
pkgs_extra <- c("BiocParallel.FutureParam", "future.tools", "future.mirai", "future.mapreduce", "marshal")
pkgs_mapreduce <- c("future.apply", "doFuture", "furrr")
pkgs_backend <- c("future.batchtools", "future.callr", "future.mirai")
pkgs <- c("globals", "listenv", "parallelly", "future", "future.tests", "progressr", pkgs_mapreduce, pkgs_backend)
pkgs_extra <- c("BiocParallel.FutureParam", "future.tools", "future.mapreduce", "marshal")
pkgs <- c(sort(pkgs), pkgs_extra)
urls <- sprintf("https://%s.futureverse.org", pkgs)
names(urls) <- pkgs
Expand All @@ -16,7 +18,7 @@ url: https://<%= pkg %>.futureverse.org
home:
links:
- text: Roadmap/Milestones
href: https://github.com/HenrikBengtsson/<%= pkg %>/milestones
href: https://github.com/<%= gsub("(^.*:|[.]git$)", "", subset(gert::git_remote_list(), name == "origin")$url) %>/milestones
- text: The Futureverse Project
href: https://www.futureverse.org/
- text: Futureverse User Forum
Expand All @@ -33,7 +35,7 @@ navbar:
text: Packages
menu:
<% for (name in names(urls)) { %>
- text: <%= name %> <% if (name %in% pkgs_extra) { %>(experimental)<% } %>
- text: <%= name %> <% if (name %in% pkgs_extra) { %>(experimental)<% } else if (name %in% pkgs_backend) { %>(backend)<% } else if (name %in% pkgs_mapreduce) { %>(map-reduce)<% } %>
href: <%= urls[name] %>
<% } %>
cran:
Expand Down

0 comments on commit e7ce24c

Please sign in to comment.