led and ledbar widget to visualize binary data #88
Conversation
|
Thanks this is very cool. |
Pull Request Test Coverage Report for Build 8478408157Details
💛 - Coveralls |
|
Hi @andydotxyz I made some tests with widget.Label but this widget inherits a lot of settings from theme (like padding for example). That make the text very hard to place under the led icon. (In alternative I would have to make a very bigger led). This object i more like a gauge so I think the text under it can be considered more like any other graphical item and in this way the coanvas.text give us more freedom to handle it. |
| var ( | ||
| counter1 int | ||
| ledbar1 *xwidget.LedBar | ||
| ledbar2 *xwidget.LedBar | ||
| ) |
There was a problem hiding this comment.
Let's not use global variables please. Use an anonymous function in the main function instead or update the run function to take in pointer parameters for the things you have to modify.
| if (state & b) == b { | ||
| w.leds[l-i].(*Led).Set(true) | ||
| } else { | ||
| w.leds[l-i].(*Led).Set(false) | ||
| } |
There was a problem hiding this comment.
You can pass in the boolean directly instead of branching.
| if (state & b) == b { | |
| w.leds[l-i].(*Led).Set(true) | |
| } else { | |
| w.leds[l-i].(*Led).Set(false) | |
| } | |
| w.leds[l-i].(*Led).Set(state & b == b) |
|
|
||
| var l int = len(w.texts) - 1 | ||
| var b int = 1 |
There was a problem hiding this comment.
| var l int = len(w.texts) - 1 | |
| var b int = 1 | |
| l := len(w.texts) - 1 | |
| b := 1 |
| if w.state { | ||
| return w.OnColor | ||
| } else { | ||
| return w.offColor | ||
| } |
There was a problem hiding this comment.
| if w.state { | |
| return w.OnColor | |
| } else { | |
| return w.offColor | |
| } | |
| if w.state { | |
| return w.OnColor | |
| } | |
| return w.offColor |
| } | ||
|
|
||
| func (h *ledRenderer) MinSize() fyne.Size { | ||
| log.Println(h.led.Size()) |
|
|
||
| func (h *ledRenderer) MinSize() fyne.Size { | ||
| log.Println(h.led.Size()) | ||
| return fyne.NewSize(h.led.Size().Width, h.led.Size().Height) |
There was a problem hiding this comment.
I'm not sure if the current size should be the minimum but this is at least simpler than what is there currently:
| return fyne.NewSize(h.led.Size().Width, h.led.Size().Height) | |
| return h.led.Size() |
Small widget that show a led representation of a binary number.