Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 fix typo in categorical variant.members #94

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

DanielPuthawala
Copy link
Collaborator

@DanielPuthawala DanielPuthawala commented Jan 15, 2025

#70 fixed a typo in CategoricalVariant.members

@brendanreardon
Copy link
Collaborator

brendanreardon commented Jan 30, 2025

Whoops I totally missed this notification. I'm sorry about that! We also made a change in 91-documentation-changes-post-ballot for this file, changing the text to

A non-exhaustive list of VRS variation objects that satisfy the constraints of this categorical variant.

I think that we talked about this a bit ago and agreed with the capitalization. I'll "undo" the change in the documentation repo so that there is not a merge conflict.

Copy link
Collaborator

@brendanreardon brendanreardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@DanielPuthawala DanielPuthawala merged commit 23c8954 into 1.x Jan 30, 2025
3 checks passed
@DanielPuthawala DanielPuthawala deleted the 70---fix-typo-in-CategoricalVariant.members branch January 30, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Review description of the CategoricalVariation.members property
2 participants