-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No major functional changes, just code polishing for smells and performance #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @adamhsparks |
I'm working my way through the paper now that I've familiarised myself with the work. Working through this package definitely helped me understand the paper. This is very neat work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is that
rain.at.TS
inSPIchanges()
must now be a matrix generated byTSaggreg()
only. This helps ensure the data quality further.rlang::arg_match()
(https://github.com/adamhsparks/SPIChanges/blob/b1c054ef94925d4b61a8061a426f8b672f6a877c/R/SPIChanges.R#L88),pkgname::fnname()
and relied on@importFrom
only,lapply()
to call them rather than repeating the same code over multiple lines (https://github.com/adamhsparks/SPIChanges/blob/b1c054ef94925d4b61a8061a426f8b672f6a877c/R/SPIChanges.R#L166, https://github.com/adamhsparks/SPIChanges/blob/b1c054ef94925d4b61a8061a426f8b672f6a877c/R/SPIChanges.R#L539),This is really nice work, @gabrielblain! Thank you for inviting me to be a part of it.