Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No major functional changes, just code polishing for smells and performance #1

Merged
merged 27 commits into from
Nov 10, 2024

Conversation

adamhsparks
Copy link
Contributor

The biggest change is that rain.at.TS in SPIchanges() must now be a matrix generated by TSaggreg() only. This helps ensure the data quality further.

This is really nice work, @gabrielblain! Thank you for inviting me to be a part of it.

@gabrielblain gabrielblain merged commit d4a5afd into gabrielblain:master Nov 10, 2024
5 checks passed
@gabrielblain
Copy link
Owner

Thanks @adamhsparks

@adamhsparks
Copy link
Contributor Author

I'm working my way through the paper now that I've familiarised myself with the work. Working through this package definitely helped me understand the paper. This is very neat work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants