chore: upgrade to polkadot 2409 #965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have not been updated:
Crate versions that have been updated:
Runtime version has been increased. |
mrq1911
requested changes
Feb 1, 2025
| let deps = crate::rpc::FullDeps { | ||
| client: client.clone(), | ||
| pool: transaction_pool.clone(), | ||
| deny_unsafe, |
There was a problem hiding this comment.
It was removed. You can find more info here paritytech/polkadot-sdk#4792
| @@ -782,6 +784,19 @@ impl<T: Config> Pallet<T> { | |||
| Ok(amount_in_and_outs) | |||
| } | |||
|
|
|||
| pub fn calculate_expected_amount_in( | |||
There was a problem hiding this comment.
There's a new method in the AssetExchange trait and I needed it in the implementation of this methd.
| @@ -146,13 +146,8 @@ impl frame_support::traits::tokens::Pay for PayFromTreasuryAccount { | |||
|
|
|||
| impl pallet_treasury::Config for Runtime { | |||
| type Currency = Balances; | |||
| type ApproveOrigin = EitherOf<EnsureRoot<AccountId>, Treasurer>; | |||
There was a problem hiding this comment.
ApproveOrigin is used only in one extrinsic, approve_proposal. The extrinsic was deprecated and replaced by spend extrinsic and SpendOrigin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
whitelist ipsin rate limiting paritytech/polkadot-sdk#3701.Changes in config params:
TODO: