Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve asynchronous tasks error handling and reporting #19448

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

davelopez
Copy link
Contributor

Closes #19419

When a Celery task failed, there was no way of getting the error message to the user to inform them exactly what the failure was.

This PR adds a new endpoint GET /api/tasks/{task_id}/result that will return the status and the final result message. In case of failures, the result message will contain the error message.

The rest of the changes adapt the task monitoring and persistence composables in the client code to display and store the error message accordingly.

Before

image

After

Screenshot from 2025-01-23 10-56-20

How to test the changes?

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez
Copy link
Contributor Author

Test failures unrelated

@davelopez davelopez force-pushed the improve_task_error_handling branch from e876f18 to e05d018 Compare January 27, 2025 09:20
@davelopez davelopez merged commit e6a42f5 into galaxyproject:dev Jan 27, 2025
53 of 57 checks passed
@davelopez davelopez deleted the improve_task_error_handling branch January 27, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow export wizard flow improvement
2 participants