-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ggplot scatterplot tool #6715
base: main
Are you sure you want to change the base?
Conversation
@bgruening ready for review |
@hechth can you please test in planemo what happens when you provide a file without a header? How does the UI react? |
Well it just will always think there is a header ... so it treats the first line as a header. |
@bgruening I added a select to choose whether there is a header or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hindsight I wish I would not have implemented galaxyproject/galaxy@2395e65.
An.extra tool that just adds metadata to a tabular file would have been better. Maybe such a tool would even be possible without duplicating the dataset.
Then you could just rely on the metadata here (and no conditional would be needed) and the user could use the additional tool to set the metadata of needed.
@bernt-matthias I'm not sure I have followed all the tabular discussions. Do you think we can merge this PR or not? |
FOR CONTRIBUTOR:
Closes #6692