Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 03-test-runner.mdx #446

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Update 03-test-runner.mdx #446

merged 3 commits into from
Jan 5, 2024

Conversation

xeontem
Copy link
Contributor

@xeontem xeontem commented Jan 1, 2024 •
edited
Loading

Important step for uploading test results.
without this step action throws an "Integration" error.

Changes

  • ...

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@xeontem
Update 03-test-runner.mdx
ed8348d 
Important step for uploading test results.
without this step action throws an "Integration" error.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2024

Cat Gif

webbertakken
webbertakken approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @davidmfinol wanna have another look?

@davidmfinol
Copy link
Member

davidmfinol commented Jan 2, 2024 •
edited
Loading

Can we move this paragraph to an earlier location on this page?
I think it makes more sense to move it to line 161, to move it closer to the description of the githubToken.

EDIT: Is this permission change just for the upload-artifact action?
I remember there's also a permission setting that gives the githubToken write permissions; is this that same setting?

@xeontem
Copy link
Contributor Author

xeontem commented Jan 4, 2024

I tested upload-artifact flow only. Cannot tell if it is actual for githubToken

Sure, moved it to line 161.

@GabLeRoux
Update instructions to list requirements properly in Viewing test res…
2ae7bab 
…ults

I mainly did this commit to format changes. Thanks to xeontem :)
@GabLeRoux
Copy link
Member

I fixed code formatting, transformed requirements into a list. Thanks for the contributions! 🎉

@GabLeRoux GabLeRoux enabled auto-merge (squash) January 5, 2024 17:18
@GabLeRoux GabLeRoux merged commit 2ddac63 into game-ci:main Jan 5, 2024
5 checks passed
@GabLeRoux
Copy link
Member

GabLeRoux commented Jan 5, 2024 •
edited
Loading

Actually, reading this again, I'll reverse point 1 and point 2 so it's easier to follow. Fixed order in #447

@GabLeRoux GabLeRoux mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbertakken webbertakken webbertakken approved these changes

@GabLeRoux GabLeRoux GabLeRoux approved these changes

@davidmfinol davidmfinol davidmfinol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xeontem @davidmfinol @GabLeRoux @webbertakken