-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Running Container as Runner Host User #600
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
+ Coverage 37.29% 37.33% +0.04%
==========================================
Files 76 76
Lines 3057 3059 +2
Branches 610 611 +1
==========================================
+ Hits 1140 1142 +2
Misses 1917 1917
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried this, it looks fine to me, but I left a few comments. I'm not exactly sure why we're changing permissions to stdout and stderr. I assume this does indeed solve issues with self-hosted runner, but I'm wondering if this should always be done or if it should be done only based on configuration 🤔
…instead. Exponential backoff Unity license activation retry strategy
Changes
runAsHostUser
to allow running the container as the same user as the host system. This fixes most permissions issues on self-hosted runners.Related PR
Related Issues
Checklist
code of conduct
in the documentation repo)