Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintainers for products #25

Merged
merged 3 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- "3.9"
- "3.10"
- "3.11"
- "3.12"

runs-on: ubuntu-20.04

Expand Down
40 changes: 40 additions & 0 deletions ci/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,46 @@ def test_env_var_expansion(self):
success=False,
)

def test_maintainers(self):
self.write_conf(
"""
version: 2
defaults:
products:
- test-dunfell
mode: mode
site: site

versions:
dunfell:
oeinit: {ROOT}/ci/dummy-init

products:
test-dunfell:
maintainers:
- name: John Doe
email: [email protected]
- name: Jane Doe
email: [email protected]
default_version: dunfell

modes:
mode: {{}}

sites:
site: {{}}

""".format(
ROOT=ROOT
)
)

self.assertShellCode(
"""\
. init-build-env
"""
)

def test_tags(self):
self.write_conf(
"""\
Expand Down
11 changes: 7 additions & 4 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
PyYAML==6.0
PyYAML==6.0; python_version < '3.8'
PyYAML==6.0.2; python_version >= '3.8'
jsonschema==3.2.0; python_version < '3.7'
jsonschema==4.17.3; python_version >= '3.7'
jsonschema==4.17.3; python_version == '3.7'
jsonschema==4.23.0; python_version >= '3.8'
tabulate==0.8.10; python_version < '3.7'
tabulate==0.9.0; python_version >= '3.7'
tqdm==4.64.1; python_version < '3.7'
tqdm==4.65.0; python_version >= '3.7'
tqdm==4.66.5; python_version >= '3.7'
yamllint==1.28.0; python_version < '3.7'
yamllint==1.32.0; python_version >= '3.7'
yamllint==1.32.0; python_version == '3.7'
yamllint==1.35.1; python_version >= '3.8'
6 changes: 6 additions & 0 deletions whisk.example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,12 @@ products:
# particularly if you use a lot of codenames (optional)
description: A test qemux86-64 product

# The list of maintainers for the product. The name of the maintainer is
# required, but the email is optional.
maintainers:
- name: John Doe
email: [email protected]

# The default version that this product will build with if unspecified, or
# if the user specifies the default should be used. The user can force a
# product to use a different version if they are feeling adventurous
Expand Down
18 changes: 18 additions & 0 deletions whisk.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,24 @@
"description": {
"type": "string"
},
"maintainers": {
"type": "array",
"items": {
"type": "object",
"properties": {
"name": {
"type": "string"
},
"email": {
"type": "string"
}
}
},
"additionalProperties": false,
"required": [
"name"
]
},
"default_version": {
"type": "string"
},
Expand Down
Loading