Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips Banker Deposit Dialogue #172

Merged

Conversation

Caladius
Copy link
Collaborator

@Caladius Caladius commented Jan 14, 2025

Skips a lot of unnecessary banter from the Banker primarily when Depositing Rupees.

I did not modify the Withdrawal Dialogue as its significantly less used in a generic rando run.

Build Artifacts

@Eblo
Copy link
Collaborator

Eblo commented Jan 18, 2025

There seems to be some weirdness with the skipped stamp animation. Normally I would advance a textbox, wait for the banker to check Link's stamp, and then get a new textbox. With this, I have to press A twice to advance some textboxes. This is characterized by the textbox end sound effect playing with each A press.

@Patrick12115
Copy link
Collaborator

What Eblo said. This happens twice, once before, once after. Also, this should not be tied to IS_RANDO as I am sure plenty of people playing vanilla would like this feature too. Maybe be tied to "Skip Misc Interactions" or "Fast Bank Selection" with an addition about it in the tooltip. Everything else seems to work properly though.

@Eblo
Copy link
Collaborator

Eblo commented Jan 26, 2025

I can confirm that my aforementioned issues are gone. I like how snappy it all is, now. However, the dialog informing the player how much they have in their bank account is now skipped. It's still technically possible to know your balance by using the max withdrawal shortcut (if it's under 1000 rupees), but I think that textbox is relevant information that should be retained if possible.

Based on event logs, the textId for that is 0x46A for both withdrawal and deposit. It's separate from the stamp checking, so I think it shouldn't have any weirdness with time-consuming animations playing out.

@garrettjoecox garrettjoecox merged commit c4dc930 into garrettjoecox:develop-rando Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants