Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ballad of windfish #180

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

balloondude2
Copy link
Collaborator

@balloondude2 balloondude2 commented Jan 17, 2025

Adds an enhancement that will play the complete Ballad of the Windfish (at the milk bar) if you have all three main transformation masks after playing one part.

Build Artifacts

@Eblo
Copy link
Collaborator

Eblo commented Jan 18, 2025

Works on my machine

@Patrick12115
Copy link
Collaborator

Works fine here, other than if you already have played as a form before getting all forms, you have to play a different form to activate the skip if you're within the same cycle. For example, if you play as Human Link and then realize you actually don't have all the masks, go out and get the last one and come back, if it's within the same cycle, since that flag was already set for Human Link playing, it's not set again, therefore not activating the skip. Playing as any of the other forms will then set their flag, thus activating the skip properly. I'm not sure if there is even a way around this, since it doesn't seem to set anything else upon second play. Just more of a note incase someone says this is not working down the road, this would be a likely reason why.

@balloondude2
Copy link
Collaborator Author

Works fine here, other than if you already have played as a form before getting all forms, you have to play a different form to activate the skip if you're within the same cycle. For example, if you play as Human Link and then realize you actually don't have all the masks, go out and get the last one and come back, if it's within the same cycle, since that flag was already set for Human Link playing, it's not set again, therefore not activating the skip. Playing as any of the other forms will then set their flag, thus activating the skip properly. I'm not sure if there is even a way around this, since it doesn't seem to set anything else upon second play. Just more of a note incase someone says this is not working down the road, this would be a likely reason why.

I'll probably need to convert this to a VB_Should in order to handle that case. Good catch.

@Eblo
Copy link
Collaborator

Eblo commented Jan 26, 2025

Can confirm it still works, even if it's disabled when playing the first time and then re-enabled before playing again in the same form and same cycle.

@balloondude2
Copy link
Collaborator Author

Finally had time to test again. Seems to still work after converting to new new menu.

@garrettjoecox garrettjoecox merged commit 4bc13b4 into garrettjoecox:develop-rando Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants