Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove Fierce Diety from logic check in Stone Tower since it's c… #210

Conversation

JoshSanch
Copy link

@JoshSanch JoshSanch commented Jan 30, 2025

…onsidered a trick for now

Build Artifacts

Copy link
Collaborator

@balloondude2 balloondude2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are there any other instances of CAN_BE_DIETY hanging around in logic?

@Eblo
Copy link
Collaborator

Eblo commented Jan 30, 2025

I'd request adding a comment in lieu of the removed logic, just so we have the reference in the future for when we do want to allow for FD trick logic of some sort.

@JoshSanch
Copy link
Author

I can definitely add that and add some TODOs in other places where I find FD logic references.

@garrettjoecox garrettjoecox merged commit de9f833 into garrettjoecox:develop-rando Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants