Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rando Alpha #5

Open
wants to merge 426 commits into
base: develop
Choose a base branch
from
Open

Rando Alpha #5

wants to merge 426 commits into from

Conversation

garrettjoecox
Copy link
Owner

@garrettjoecox garrettjoecox commented Sep 18, 2024

Please read the known issues & TODO lists below before reporting any bugs or requesting any features.

This is an alpha, please treat it as such. Autosave is heavily recommended. Randomizer Saves are currently locked to the version you created them on, so do not updated unless you intend on starting a new seed. We may lift this restriction later on, but for now it's aim is to minimize cross version confusion/bugs.

Downloads

Known Issues:

  • When I have powder keg I cannot take the Goron test - Blowing up the boulder to open up the race track will award you the check, we'll redo this at some point
  • / Character (maybe others) in seed input causes seed generation to fail
  • Monkeys in Southern swamp continue to show up, and in the wrong places
  • Some torches will not re-light a deku stick after they have been lit (related to one point skip)
  • Hive in Termina Field Bio Grotto doesn't drop an item if you destroy it with a hookshot
  • Drinking green potion before you have magic, grants you infinite magic!
  • Oceanside Spider House person does not give check after the First Day Oceanside Spider House squatter fixes #206
  • Postman minigame timer did not disappear even though player did not have bunny hood (maybe upstream bug related to persistent mask enhancement?)
  • Freestanding check in Snowhead Temple icicle room appears too high in the air, making collection difficult
  • Strange camera and music behavior after defeating two Dinolfos in Snowhead Temple
  • Occasional crash in both Spider Houses upon load. Graphics related, seemingly usually DirectX, and it may be caused by the Skulltula token HUD icon, which displays varying garbage colors on the bottom row of pixels when it doesn't crash. Native hardware does not have that bottom row of pixels (Upstream bug, most likely)
  • Reports of Room Key check not being rewarded, but having trouble reproducing
  • Freestanding items aren't boomerang-able again

TimeSavers TODO:

  • GBT Waterfall w/ Ice arrow cutscene active
  • Moon crash CS [Enhancement] Add Moon Crash Cutscene Skip to Misc Interactions time savers HarbourMasters/2ship2harkinian#970
  • Scrub from clock town (through telescope)
  • Skip Iron Knuckle armor drop cutscene (to preserve ISG)
  • Second time blue warp CS not skipped
  • Goron Lullaby Biggoron cs
  • Goron Graveyard grave pull
  • Dampe digging, Big Poe spawn
  • Gekko/Snapper miniboss CS
  • Marine Laboratory egg dropping CS
  • Gomess spawn CS (may be like other boss CS)
  • Eyegore death CS
  • Kafei running back to Clock Town after Sakon's Hideout CS
  • Kafei/Anju reunion CS
  • Goron race intro (normally plays only the first time, while subsequent races already skip it in vanilla)

New Feature/QOL/Tweaks TODO:

  • Pressing B on “Would you like to save” screen goes back to menu, inconsistent with oot (Pressing B on “Would you like to save” screen goes back to menu FIX. #62 but this needs to be directed upstream)
  • Fix for not being able to pause on 4th day
  • The Great Fairy Mask cs makes it seem like you're getting the Great Fairy Mask
  • Add Skulltula tokens to the Item Tracker
  • Literally nothing no sparkles in deku playground and Odalwa's Lair
  • Freestanding in front of secret shrine don't all pick up if you have GI skips disabled
  • Allow arrow cycle with R instead of L (point to upstream)
  • Stop link from diving over water (point to upstream)
  • Checks.cpp structure only allows for one scene, but some checks exist in multiple scenes (e.g. Keaton quiz, stolen bomb shop goods)
  • A general pass on performance (The check tracker can cause some performance issues, particularly on lower-end hardware).

UI TODO:

  • We're awaiting a larger UI code cleanup prior to expanding the Rando options menus
  • Item Tracker hides everything by default

Logic Fixes TODO:

  • Another pass on small key logic
  • Another pass on events and how they work with the live tracker
  • Verify if Deku bubbles can knock down the pirate fortress beehive (to access hookshot chest)

Checks TODO

  • Ghost Hut HP
  • Gorman Track Milk Purchase
  • Great Bay Coast Fisherman HP
  • Termina Field Gossip Stones HP
  • Termina Field Scrub
  • Milk Bar Purchase Chateau Rando: Add Checks for Milk Bar NPC Shop #205
  • Milk Bar Purchase Milk Rando: Add Checks for Milk Bar NPC Shop #205
  • Mountain Village Frog Choir HP
  • Pinnacle Rock HP
  • Post Office HP
  • Tourist Information Tingle Picture
  • Chest Game HP
  • Missing freestanding: Red rupees under Smithy's stairs in Spring, 8 blue rupees near Inverted STT Boss door.

2nd Pass TODO:

These checks are "implemented" but either have problems or haven't been thoroughly tested

  • RC_KAFEIS_HIDEOUT_LETTER_TO_MAMA - Check works, but notebook event for this check does not
  • RC_SOUTHERN_SWAMP_SCRUB_BEANS - Won't sell you this check if you are full on beans, also won't let you buy beans unless you buy this check, which may be un-obtainable (ammo or magic refill)
  • RC_GORON_VILLAGE_MEDIGORON Need to redo this check, it works fine if you have the skip powder keg test enabled but is weird if it's not.
  • another pass on the Circus Leader Mask check (seems to have a long pause before getting the item, can't speak to Toto afterwards if GI animation skipped)
  • Scrubs need to more gracefully handle when deeds are traded out and they are available in another location
  • "Get both rewards if perfect" enhancement relies on a high score static variable that needs to be reset somehow
  • Any instances of CustomMessage::Replace likely need replaced with entirely new messages for version compatibility Revise hints to not rely on existing text data #199
  • RC_OCEAN_SPIDER_HOUSE_WALLET man seems to immediately appear inside house, instead of at entrance, upon collection of all tokens Oceanside Spider House squatter fixes #206
  • Bomb bag theft cs can softlock if one of the actors is targeted and talked to right at the moment of theft
  • Beaver race should only require 2 for 2 checks, not 4 for 2 checks
  • Putting baby to sleep might prevent you from getting Lullaby intro check (from dad)
  • Add a ShouldOpenText to go along with OnOpenText so we can prevent textboxes without making one-off VB_SHOULDs
  • Milk Run archery portion seemingly starting too soon in some circumstances
  • RC_STOCK_POT_INN_TOILET_HAND softlock with Ocean Title Dead on second cycle getting this check.

Build Artifacts

@garrettjoecox garrettjoecox force-pushed the develop-rando branch 5 times, most recently from dcc4385 to 5900ce7 Compare September 18, 2024 21:36
@garrettjoecox garrettjoecox force-pushed the develop-rando branch 8 times, most recently from aec8be5 to 0a70999 Compare September 28, 2024 15:17
@garrettjoecox garrettjoecox force-pushed the develop-rando branch 2 times, most recently from 9c21f3b to 7ef92ea Compare October 2, 2024 19:56
@garrettjoecox garrettjoecox force-pushed the event-queue branch 3 times, most recently from 7d69982 to 41d77dd Compare October 6, 2024 05:22
@garrettjoecox garrettjoecox force-pushed the develop-rando branch 2 times, most recently from 5b03ae0 to ad65538 Compare October 9, 2024 19:25
@garrettjoecox garrettjoecox force-pushed the develop-rando branch 3 times, most recently from f6035bd to 423e990 Compare October 27, 2024 00:03
garrettjoecox and others added 30 commits January 20, 2025 22:26
* Shuffle Kotake Red Potion Bottle

* Logic... OH YEA!

* Fix Woods Kotake

* clang

* Final fix?

* clang

* ship it

* update cycleObtained
* Shuffles Zora Hall Scene Lights

* Add Logic
* Made access to the upper section of Road to Ikana also check for Gibdo Mask.

* Made macro for checking for Red or Blue potion. Made Stone Mask check for potion access.

* Removed the HAS_ACCESS_TO_POTION_REFILL macro by request.
* add evan's check and a cs skip

* clean up includes

* update logic
* first pass

* make sure the captain is gone after he's defeated

* no `|| IS_RANDO`

* clean up

* newline

* clean up again

* clang-format

---------

Co-authored-by: Garrett Cox <[email protected]>
* Shuffles Marine Lab Fish Heart Piece

* Adds Logic

---------

Co-authored-by: Garrett Cox <[email protected]>
* Skips unneccesary Banker Deposit Interactions.

* Correct Should Usage

* Update to SkipMiscInteractions CVAR, new file and dialogue fixes/cleanup

---------

Co-authored-by: Garrett Cox <[email protected]>
* Fix Captain defeat CS UB

* Change headers for SkipDefeatCaptainSequence.cpp
* skip ballad of windfish

* simplify

* convert to should

* convert to new menu?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.