Fe e2e liq id locators updates (#521)

gasp-xyz · Oct 30, 2024 · 89e5935 · 89e5935
1 parent 5746ba7
commit 89e5935
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 16 deletions.
diff --git a/.github/workflows/gasp-prod-smoke-test.yml b/.github/workflows/gasp-prod-smoke-test.yml
@@ -175,18 +175,18 @@ jobs:
             testmo report: https://mangata-finance.testmo.net/automation/runs/view/${{needs.setup-report.outputs.testmo-run-id}}"
           GITHUB_REF: "https://mangata-finance.github.io/mangata-e2e/${{ github.run_number }}"
 
-  # slack-notify-nook:
-  #   needs: [e2e-tm]
-  #   if: failure()
-  #   runs-on: ubuntu-latest
-
-  #   steps:
-  #     - name: Slack Notification - Error
-  #       uses: bryannice/[email protected]
-  #       env:
-  #         SLACK_INCOMING_WEBHOOK: ${{ secrets.STG_SLACK_WEBHOOK }}
-  #         SLACK_TITLE: "PROD GASP smoke UI tests - results - NOOK"
-  #         SLACK_COLOR: "#ff0011"
-  #         SLACK_MESSAGE: "Test failures [ ${{ env.TEST_SCRIPT }} ]
-  #           testmo report: https://mangata-finance.testmo.net/automation/runs/view/${{needs.setup-report.outputs.testmo-run-id}}"
-  #         GITHUB_REF: "https://mangata-finance.github.io/mangata-e2e/${{ github.run_number }}"
+  slack-notify-nook:
+    needs: [e2e-tm]
+    if: failure()
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Slack Notification - Error
+        uses: bryannice/[email protected]
+        env:
+          SLACK_INCOMING_WEBHOOK: ${{ secrets.STG_SLACK_WEBHOOK }}
+          SLACK_TITLE: "PROD GASP smoke UI tests - results - NOOK"
+          SLACK_COLOR: "#ff0011"
+          SLACK_MESSAGE: "Test failures [ ${{ env.TEST_SCRIPT }} ]
+            testmo report: https://mangata-finance.testmo.net/automation/runs/view/${{needs.setup-report.outputs.testmo-run-id}}"
+          GITHUB_REF: "https://mangata-finance.github.io/mangata-e2e/${{ github.run_number }}"
diff --git a/test/rollup-test/rollup-main.my-positions.test.ts b/test/rollup-test/rollup-main.my-positions.test.ts
@@ -34,7 +34,7 @@ let acc_addr_short = "";
 const ETH_ASSET_NAME = "ETH";
 const GASP_ASSET_NAME = "GASPV2";
 
-describe("Gasp UI swap tests", () => {
+describe("Gasp UI my positions tests", () => {
   let sidebar: Sidebar;
   let myPositionsPage: MyPositionsPage;
 

diff --git a/utils/frontend/rollup-pages/MyPositionsPage.ts b/utils/frontend/rollup-pages/MyPositionsPage.ts
@@ -47,6 +47,12 @@ export class MyPositionsPage {
   }
 
   async isLiqPoolDisplayed(firstTokenName: string, secondTokenName: string) {
+    const PoolName = firstTokenName + " / " + secondTokenName;
+    const xpath = buildXpathByElementText("span", PoolName);
+    return isDisplayed(this.driver, xpath);
+  }
+
+  async isLiqPoolDisplayedIds(firstTokenName: string, secondTokenName: string) {
     const PoolName = "pool-" + firstTokenName + "-" + secondTokenName;
     const itemXpath = buildDataTestIdXpath(PoolName);
     return isDisplayed(this.driver, itemXpath);
@@ -73,6 +79,12 @@ export class MyPositionsPage {
   }
 
   async clickPoolPosition(firstTokenName: string, secondTokenName: string) {
+    const PoolName = firstTokenName + " / " + secondTokenName;
+    const xpath = buildXpathByElementText("span", PoolName);
+    await clickElement(this.driver, xpath);
+  }
+
+  async clickPoolPositionHref(firstTokenName: string, secondTokenName: string) {
     const PoolName = "/positions/" + firstTokenName + "-" + secondTokenName;
     const hrefXpath = buildHrefXpath(PoolName);
     await clickElement(this.driver, hrefXpath);