Feature/create docker image #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncer
commented
Oct 31, 2023
| ### how to build ## | ||
| #### cd ~/projects/microapps ; docker build -f /home/goncer/projects/mangata-e2e/devops/dockerfiles/feTests/Dockerfile . | ||
| ## how to run | ||
| #### docker run -it --network=host --entrypoint=/bin/bash ca7dfc5ecc66 -c "yarn nx serve dex & sleep 10000000000" #### |
There was a problem hiding this comment.
@MariuszSzpyt plz take a look and share w. me your thoughts.
There was a problem hiding this comment.
Looks good, for now however it wont run microapps as its not getting it from anywhere (as the api key part is provided).
goncer
commented
Oct 31, 2023
| # WORKDIR / | ||
| # RUN if test -z ${GITHUB_TOKEN} ; then git config --global url."https://${GITHUB_TOKEN}@github.com/".insteadOf "https://github.com/" ; git clone -b ${FE_BRANCH} https://github.com/mangata-finance/microapps.git ; fi | ||
|
|
||
| ADD . /microapps/ |
There was a problem hiding this comment.
yes, is copying it from the folder you are running the docker build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.