Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature: Merge mangata-node repository code (#411)" #415

Closed
wants to merge 2 commits into from

Conversation

vanderian
Copy link
Contributor

This reverts commit ed4a6cd.

vanderian and others added 2 commits January 22, 2025 12:53
* remove unused try_into impl

* align tests

* get rid of FailedWithdrawalResolution

* report status of processing request

* manual refund for failed deposits

* trigger maintenance mode of cancel_resolution failure

* bump sdk

* apply formatting

* [MGX-1369] connect with jira

* [MGX-1193] connect with jira

* remove not needed test

* add new group of tests

* [MGX-1370] Align manual batches

* Test for specific behaviour agreed with product team

* [MGX-1366] - BEX - Maintanance mode alignments

* align formatting

* add: disable mocks in tests on demand

* test_sequencer_updates_are_ignored_and_removed_in_maintanance_mode

* align maintanance mode behaviour

* test that same l1update can be provided again if was skipped in maintanance mode

* feat: Add multi-platform Docker image build for arm64 platform support MGX-1326 (#792)

• Support multiple architecture builds 
• Improve cross-platform compatibility

MGX-1326

* return read rights while skipping sequencer updates in maintanance mode

* Provide specific error when withdraw not existing token

* extract helpers methods for batch creation

* [MGX-1366] - add 'force_create_batch'

* [MGX-1417] Only deposit recipient can refund failed deposit

* typo 'TokenDoestNotExist' -> 'TokenDoesNotExist'

* [MGX-1184] Store prometheus metrics as u128

* [MGX-1220] Make sure that MaxSequencers limits is applied per chain

* [MGX-1220] new 'StakeAction' parameter that determines wheter sequencer is expected to join active set

* Update Gasp erc20 address for test environment

* [MGX-1189] BEX - Contract/Node - Event observability

* trigger ci

* add 'StakeRemoved' event

* Align protocol messages with ferries

* issuance for sequencers, sequencer rewards, withdraw fee in rolldown (#803)

+ modify issuance to add sequencer vaault
+ modify sequnecer staking to add rewards
+ modify staking to call sequncer payout hook
+ modify rolldown to add sequencer update authorship hook for rewards
+ modify rolldown to add flat withdraw fee
+ modify bunch of mocks to impl issuance changes

* rename group

* ci: add multiplatform image build for fast runtime image (#809)

* deposit ferry impl

* support ferries of failed deposits

* add tests for abi compatiblity

* implement ConvertBack for address converter

* add: ferry_deposit_unsafe

* add: update_hash parameter for update_l2_from_l1

* reject updates with wrong hash

* rename 'NotMangataLiquidityAsset' => 'NotPairedWithNativeAsset'

* fix cancel rights settlement

* Feature/upgrades (#811)

* do not allow for ferry deposits that were already ferried

* add test group

* [MGX-1123] change withdraw fee to per chain vs const (#818)

* [MGX-1443] Feature/foundation membership (#819)

add membership pallet used to manage foundation members

only allowed method is for the member to change his key

* split withdrawal rolldown tests

* update token address

* use type prefix when calculating the L2Request hash

* Revert "[GASP-1564] Include request type in request hash calculation"

* use type prefix when calculating the L2Request hash

* make rpc api return purly encoded structs

* prove that aliases can be freed up

* [FIX] produce batches even when all sequencers have left

* limit manual batch size with the AutomaticBatchSize

* fix typo

* add group

* Reproduce problem reported by audit company

* fix: sequencer alias cleanup

* Feature/rolldown benchmarks (#831)

Rolldown benchmarks

* fix cargo refs (#834)

fix cargo refs

* added offset to VerExtrinsicBaseWeight and FeeLockWeight to xyk extri… (#837)

added offset to VerExtrinsicBaseWeight and FeeLockWeight to xyk extrinsics

* checkpoint

* compiled

* all compiles

* unit tests passes

* ut & benchmarks works

* allign tests

* simplify

* on_idle hook

* on_idle hook

* properly account for corner case scenario

* on_idle hook fixed

* allign tests

* remove outdated comment

* account for big reads/writes

* base integration (#839)

base integration

* different dispute period per l1

* different dispute period per l1

* tests for dispute period set

* [GASP-1632] - stop processing on first failed request

* allign with base

* configure features

* adjust dispute period

* Feature/stable pool mgx 1307 (#838)

Co-authored-by: Marian Vanderka <[email protected]>

* fix update validation

* Feature/market improvs (#845)

- RPC add calc_price_impact variant
 - fix swap buy call missing in feelock filter
 - adjust create pool to infer fixed rate from initial deposit

* GASP-1625 Feature/locked tokens (#841)

adds checks for non transferable tokens

`--features=unlocked` removes such restrictions

runtime cofing defines the native currency - `0` as non transferable
token

tokens all transfer calls, set_balance, mint extrinsics are checked
market create, mint, burn are checked
market swaps are allowed

foundation members have veto over:
market create_pool & burn

* expose feature in cargo, and disable for fast-runtime

* apply benchmarks

* revert changes to pallet vesting

* Added chain genesis salt to system genesis (#848)

* CI: Add additionoal unlocked runtime image build in CI (#850)

Introduce a separate build process for Docker images with an unlocked
runtime, along with the necessary adjustments to export WASM artifacts
and manage image manifests.

* bumped gaspErc20Mock addresses in chain spec (#852)

* fixes gasp-1666 gasp-1671 (#851)

limit withdrawals recipient to sender's address for nontransferable
tokens
ensure withdraw amount >= ferry tip

* adds maintenance check for ferry deposit calls (#846)

* Use -unrestricted for e2e non-fast tests (#849)

* Fix/seq dies (#853)

* Fix/rewards notransfer GASP-1688 (#857)

* adds a check that only single ferry can happen on a deposit request gasp-1652 (#858)

* Fix/market mint ratio gasp-1689 (#859)

fix calculate expected method
fix mint liq to respect fixed ratio
fix tests

* remove patch

* Fix/rewards market GASP-1681 (#855)

* fixes the symbol naming for liq pools (#860)

* safety precautions for on_idle hook

* fixe while loop causing crash & add u512 to avoid overflows for maxxe… (#865)

+ adjust bench to use unbalanced values
+ add minmax pool test

* Fix/mint activate lp gasp-1712 (#866)

* minimal set of changes to disable sequencer registration for non sudo users

* runtime parameters modifications

* duplicate existing config

* ethereum-mainnet chainspec

* working chainspec

* foundation accounts

* council accounts

* update issuance config

* adjust issuance config

* adjust values to avoid zero devision

* set immediate release of TGE - not used either way

* adjust issuance so 5M of GASP is minted in genesis block & account for it in issuance config

* update node url

* adjust minimum stake amount

* fix execution queue progression

* revert sequencers balances

* fix pallet-sequencer-staking tests

* fix integration tests

* align rolldown benchmarks

* fix formatting

* 1st Runtime Upgrade on Rollup Prod Alphanet: Issuance Edits (#876)

1st Runtime Upgrade on Rollup Prod Alphanet
 
 Changed issuance behaviour and changed issuance config
 
 Bumped spec_version and impl_version

* minor fixes

* remove dummy test

* fix execute_tge benchmarks

* add missing check

* fix formatting

* fix

* move to gasp-node subdir for monorepo

* adds gasp-node workflow

* ci: update GHA workflows to run `gasp-node` build and tests on opened pull requests

* fix: update permissions in reusable-gasp-node-e2e-tests GHA workflow

* fix: update Docker login secrets in reusable GHA workflow

* ci: update job names in GitHub Actions workflows for clarity and consistency

* fix: update JOB_CACHE_PREFIX and add context for gasp-node in reusable build workflow

* chore: test if workflows will work without extra setup-gcloud step

* feat: add rust-toolchain.toml for `gasp-node`

* Revert "chore: test if workflows will work without extra setup-gcloud step"

This reverts commit 964ce24.

* feat: add rust-src component to rust-toolchain.toml for gasp-node

* fix: add actions/checkout step for multiplatform image generation job to fix integration with global working-directory config

* chore: update JOB_CACHE_PREFIX for gasp-node in reusable workflow

* fix: update Docker build context paths in reusable gasp-node workflow to use git default context

* feat: merge `stash` service builds to main workflow

* Revert "fix: update Docker build context paths in reusable gasp-node workflow to use git default context"

This reverts commit 36cb10d.

* ci: merge foundry smart contracts checks into the main build and test reusable workflow

* fix: foundry-toolchain version reference

* fix: update job name in reusable build and test workflow

* fix: add missing bun install step in reusable build and test workflow

* chore: temporary disable `bun run analyze:ci`

* feat: add `slither-action` usage for `contracts` checks

* ci: move `stash` build to reusable-build-and-test.yml and rearrange `contracts` check stesp

* ci: add `reusable-gasp-node-performance-tests.yml` workflow for future integration into the workflows

* fix: syntax warnings

* chore: rearrange jobs sequence

* feat: add workflow updates for `branch-main.yml` workflow to support `mangata-node` builds

* fix: gasp-node generate types jobs

* fix: add proper permissions for `slither-action` operation

* chore: update AVS services build job name for clarity in GHA workflows

* chore: revert temporary changes to test `branch-main.yml` workflow

* chore: get rid of annoying GHA warnings caused by some bug
More details here: actions/runner-images#10636

* fix: wasm artifact upload paths

* chore: debug var

* Revert "chore: debug var"

This reverts commit 495d01c.

* fix: gasp-node image version propagation to generate-types workflow

* chore: temporary disable longest jobs

* chore: remove redundant configs from `gasp-node` codebase

* fix: NODE_DOCKER_IMAGE variable reference for reusable-gasp-node-e2e-tests.yml

* Revert "chore: temporary disable longest jobs"

This reverts commit ecd70ba.

* fix: set working directory for gasp-node in reusable-gasp-node-e2e-tests.yml

* fix: update default branch for e2e tests to eth-rollup-develop

* fix: use new var to set correct gasp-node docker compose network when running e2e tests

* fix: remove redundant variables from e2e workflow

* ci: rearrange jobs sequencing for gasp-node buiild to save a few minutes

* fix: jobs permission propagation

* feat: prepare reusable-rust-build.yml to support gasp-node builds

* feat: move gasp-node unit tests and coverage report runs to separate reusable job

* revert: put back the eth-rollup-develop branch to be used for fetching gasp-xyz/gasp-e2e repo within workflow

* [GASP-1840] Root configurable issuance config (#878)

* [gasp-1863] Feature/transfer allowlist (#882)

gasp-node has a new membership pallet that allows following calls for
ROOT:

add_member, remove_member, swap_member, reset_mebers

set_prime, clear_prime are disabled

 

orml tokens pallet adds an allowlist that overrides non-transferablitiy
for following methods:

transfer, transfer_keep_alive, transfer_all

force_transfer(origin, from, to, ...) does an allowlist check on the
from param

* [GASP-1826] reverts swap trx fees (#877)

swaps always pays commission
min fee fix
fee goes to trsy, bnb, pool
fix valuation where it applies to the real, not predicted swap value

---------

Co-authored-by: goncer <[email protected]>

---------

Co-authored-by: Mateusz Nowakowski <[email protected]>
Co-authored-by: Aleksandr Chetverov <[email protected]>
Co-authored-by: AlexChetverov <[email protected]>
Co-authored-by: mateuszaaa <[email protected]>
Co-authored-by: Misha Kolesnik <[email protected]>
Co-authored-by: mateuszaaa <[email protected]>
Co-authored-by: iStrike7 <[email protected]>
Co-authored-by: goncer <[email protected]>
@vanderian vanderian requested a review from mateuszaaa January 22, 2025 13:51
Copy link
Contributor

@tenequm tenequm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants