Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.4 Deprecation fix #63

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

PHP8.4 Deprecation fix #63

wants to merge 2 commits into from

Conversation

davisriska
Copy link

@davisriska davisriska commented Jan 13, 2025

Fixes PHP 8.4 deprecation warnings/errors

I first tried array|null and ?array but they were added in PHP8.0 and PHP7.1 respectively. So I reviewed what happens with the null and it just gets ignored with the if. I think this fix should work with 5.4.

Shapefile\Geometry\MultiPolygon::__construct(): Implicitly marking parameter $polygons as nullable is deprecated, the explicit nullable type must be used instead
Shapefile\Geometry\GeometryCollection::__construct(): Implicitly marking parameter $geometries as nullable is deprecated, the explicit nullable type must be used instead
Shapefile\Geometry\MultiPolygon::__construct(): Implicitly marking parameter $polygons as nullable is deprecated, the explicit nullable type must be used instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants