Fix binary string comparison failure #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gasteve The checksum verification is currently broken. Are there any comments that can be addressed to get this PR merged? |
|
@gasteve Closing due to inactivity, but you should really fix this. Publishing cryptographic libraries, then not updating their vulnerabilities is malicious behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While replacing replacing bitpay/bitcore's base58 lib with
base58-nativeas a dep, their tests failed due to this patch:bitpay/bitcore#402
It seems that comparing strings generated with
Buffer.toString()will give false positives for some special characters. Their solution was to encode the bytes as hex before comparison.Fixes #10.