-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing parts to the CMakeLists.txt
code.
#400
Conversation
…CMakeLists.txt file. Signed-off-by: Johan Rutgeerts <[email protected]>
Thanks, this should reflect https://github.com/gazebosim/gz-msgs/blob/gz-msgs10/examples/generating_custom_msgs/CMakeLists.txt, but it maybe got out of sync at some point. |
Added |
… the CMakeLists.txt file to correspond to the tutorial. Signed-off-by: Johan Rutgeerts <[email protected]>
Ok, in hindsight that is obvious, but I didn't realise there was an 'examples' folder. I've added a reference to the tutorial so the reader knows where to find the code. |
Signed-off-by: Michael Carroll <[email protected]>
@jrutgeer looks like one minor doctest issue here:
|
Signed-off-by: Johan Rutgeerts <[email protected]>
@mjcarroll removed the </br> |
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-msgs10 #400 +/- ##
==========================================
Coverage 97.67% 97.67%
==========================================
Files 27 27
Lines 1163 1163
==========================================
Hits 1136 1136
Misses 27 27 |
As of yet, copy-paste of the tutorial code does not compile.
First error message:
This is due to
${GZ_MSGS_VER}
not being set.After rectifying this, another error results:
This is due to
${MSGS_PROTOS}
not being set.This PR adds these variable definitions to the example code, and also some extra documentation on the use of the
${GZ_MSGS_VER}
variable.