Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing parts to the CMakeLists.txt code. #400

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Added missing parts to the CMakeLists.txt code. #400

merged 7 commits into from
Nov 3, 2023

Conversation

jrutgeer
Copy link
Contributor

As of yet, copy-paste of the tutorial code does not compile.

First error message:

get_target_property() called with non-existent target "gz-msgs::gz-msgs"

This is due to ${GZ_MSGS_VER} not being set.

After rectifying this, another error results:

Missing input file.

This is due to ${MSGS_PROTOS} not being set.

This PR adds these variable definitions to the example code, and also some extra documentation on the use of the ${GZ_MSGS_VER} variable.

@jrutgeer jrutgeer requested a review from caguero as a code owner October 13, 2023 14:43
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 13, 2023
@mjcarroll
Copy link
Contributor

Thanks, this should reflect https://github.com/gazebosim/gz-msgs/blob/gz-msgs10/examples/generating_custom_msgs/CMakeLists.txt, but it maybe got out of sync at some point.

@azeey
Copy link
Contributor

azeey commented Oct 13, 2023

Added CMakeLists.txt to gazebosim/gz-cmake#387. Once that's resolved, we should be able to use \snippet instead of copying example code in the tutorial.

… the CMakeLists.txt file to correspond to the tutorial.

Signed-off-by: Johan Rutgeerts <[email protected]>
@jrutgeer
Copy link
Contributor Author

Thanks, this should reflect https://github.com/gazebosim/gz-msgs/blob/gz-msgs10/examples/generating_custom_msgs/CMakeLists.txt, but it maybe got out of sync at some point.

Ok, in hindsight that is obvious, but I didn't realise there was an 'examples' folder. I've added a reference to the tutorial so the reader knows where to find the code.

@mjcarroll mjcarroll self-assigned this Oct 23, 2023
@mjcarroll mjcarroll self-requested a review October 23, 2023 17:04
@mjcarroll
Copy link
Contributor

@jrutgeer looks like one minor doctest issue here:

/github/workspace/tutorials/message_generation.md:124: warning: Illegal </br> tag found

Signed-off-by: Johan Rutgeerts <[email protected]>
@jrutgeer
Copy link
Contributor Author

jrutgeer commented Nov 3, 2023

@mjcarroll removed the </br>

Signed-off-by: Michael Carroll <[email protected]>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #400 (8356265) into gz-msgs10 (25759b6) will not change coverage.
The diff coverage is n/a.

❗ Current head 8356265 differs from pull request most recent head a546ff2. Consider uploading reports for the commit a546ff2 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #400   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           

@mjcarroll mjcarroll merged commit 3d60486 into gazebosim:gz-msgs10 Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants