Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recoverylog: relax FSM to allow updating the content of a property #356

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jgraettinger
Copy link
Contributor

@jgraettinger jgraettinger commented Dec 11, 2023

In certain situations, if a RocksDB doesn't fully initialize then it may re-create its IDENTITY file upon the next next open attempt.

Currently this is prohibited by FSM but should be relaxed.


This change is Reviewable

In certain situations, if a RocksDB doesn't fully initialize then it may
re-create its IDENTITY file upon the next next open attempt.

Currently this is prohibited by FSM but should be relaxed.
@jgraettinger jgraettinger requested a review from psFried December 11, 2023 19:34
Copy link
Contributor

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we found our reason to allow it. LGTM

@jgraettinger jgraettinger merged commit 128bdd7 into master Dec 11, 2023
1 check passed
@jgraettinger jgraettinger deleted the johnny/update-property branch December 11, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants