Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-connect): init package #1648

Merged
merged 10 commits into from
Oct 3, 2024
Merged

feat(wallet-connect): init package #1648

merged 10 commits into from
Oct 3, 2024

Conversation

nikitayutanov
Copy link
Member

Create @gear-js/wallet-connect library for a standardized wallet connection UI across applications.

@ereburg
Copy link
Collaborator

ereburg commented Oct 2, 2024

Maybe better propname for choosing ui styles "gear" or "vara" would be theme instead of variant?
"Variant" for me is more about visual design of component or button, eg.: outline, inline, flat, ghost, etc. And, yes, those variants should be standardized across ui design systems.

@nikitayutanov
Copy link
Member Author

Maybe better propname for choosing ui styles "gear" or "vara" would be theme instead of variant? "Variant" for me is more about visual design of component or button, eg.: outline, inline, flat, ghost, etc. And, yes, those variants should be standardized across ui design systems.

I was considering theme as a prop name and decided not to go with it, cuz theme sometimes is used in the context of dark/light mode, therefore can be confusing. No reason to believe that we will have it one day, but who knows, vara in dark mode looks promising.

I see your point, however variant there was intended to be interpreted as a simplified version of uiVariant.

What makes more sense to you:
variant to define UI kit and theme to define dark/light mode
or theme to define UI kit and mode to define dark/light mode?

@vraja-nayaka would like to know your opinion too.

@ereburg
Copy link
Collaborator

ereburg commented Oct 3, 2024

What makes more sense to you:

variant to define UI kit and theme to define dark/light mode

or theme to define UI kit and mode to define dark/light mode?

As for me, it is much more convenient to have certain namespaces like vara/gear to use it in our themes (as it is) and have some variations/modes of those themes like dark/light/pink/etc.

@nikitayutanov
Copy link
Member Author

As for me, it is much more convenient to have certain namespaces like vara/gear to use it in our themes (as it is) and have some variations/modes of those themes like dark/light/pink/etc.

Okay, will make a change in the next PR.

@nikitayutanov nikitayutanov merged commit 578371e into main Oct 3, 2024
13 checks passed
@nikitayutanov nikitayutanov deleted the ny-wallet-connect branch October 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview C1-feature Feature request D2-tools Tools and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants