-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vara-ui): upd inputs #1694
base: main
Are you sure you want to change the base?
Conversation
border-radius: 4px; | ||
background-color: #ffffff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't put white background color as we can't guarantee that every application's background will be white too. It should be transparent.
@@ -63,6 +64,7 @@ const Input = forwardRef<HTMLInputElement, Props>( | |||
className={cx(styles.input, styles[size], error && styles.error)} | |||
placeholder={placeholder} | |||
ref={ref} | |||
disabled={disabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled
is applied from attrs
destructuring already.
Another comments from previous PRs about UX and our style practices applies there too. |
Also, regarding general approach to dark mode styles. What do you think about creating mixin, that will abstract dark mode for a certain element?
to utilize it like that:
If it's working as expected, I believe it would be far easier to control color variations in the scope of a certain element. |
No description provided.