-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project from token #24
base: main
Are you sure you want to change the base?
Conversation
…... if the project has not been initialized
@12rambau, I think there's something that doesn't allow to run the workflow jobs |
that's normal you are a first time contributor on this one. Let authorize it |
I'll take time to review it on sunday but as it is i think i won't let it fly. The reason why I force users to set the EARTHENGINE_PROJECT variable even when normal credentials are used is that i cannot rely on credentials to access the cloud project name consistently. So if any downstream code needs this variable then your test will only work with personnal token. I reported it in the Google issue tracker and I think it's a major flow of the project implementation: https://issuetracker.google.com/issues/325020447 |
@12rambau, I understand the issue, but what if we set the |
To make this package more useful not only for ee service accounts, I have added the following:
EARTHENGINE_TOKEN
secrets, and make the authentication process optional when there is one or the otherearthengine authenticate
, there is a way to set a project, you can do it by usingeartheingine set_project "project_name"
, and the value will be stored in the credentials file, I have modified the initialization method so it can get the project from there.I hope I have gotten your idea with this.