Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation procedure improvements #378

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Installation procedure improvements #378

wants to merge 23 commits into from

Conversation

sylvinite
Copy link
Member

Description

Changes written as part of the NGP integration.

  • interrupted installation now hard resets E.Coli. to avoid fragmented installation
  • Installation target file for streptococcus changed, to resolve interrupted installation
  • Included htslib image to natively support tabix and bgzip
  • Fixed a bug that prevented pipeline from correctly guessing misspelled profiles
  • Removed sudo requirement from apptainer container creation (only required for older versions of apptainer) to streamline installation
  • Light installation doc updates
  • Updated NGP config file

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

Either describe a procedure, or add data; that confirms that the PR resolves what it sets out to do

Sign-offs

  • Code reviewed by @genomic-medicine-sweden/jasen-devs
  • Code tested by @genomic-medicine-sweden/jasen-devs

@sylvinite sylvinite requested a review from a team as a code owner January 13, 2025 12:09
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the CHANGELOG please:)

@ryanjameskennedy
Copy link
Collaborator

Could you also sort out this issue while you're at it please. Both container/Makefile and the main Makefile will need to be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants