Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

390 fix threads parameter in medaka #391

Merged
merged 6 commits into from
Jan 31, 2025
Merged

390 fix threads parameter in medaka #391

merged 6 commits into from
Jan 31, 2025
+6 −5

Conversation

Emkago
Copy link
Contributor

@Emkago Emkago commented Jan 29, 2025 •
edited
Loading

Description

Medaka failed, reported invalid option.

Summary of the changes made:

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

Replacing --threads with -t fixes the problem.

Sign-offs

@Emkago Emkago requested a review from a team as a code owner January 29, 2025 17:02
@Emkago Emkago linked an issue Jan 29, 2025 that may be closed by this pull request
Fix threads parameter in medaka #390
Closed
ryanjameskennedy
ryanjameskennedy approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Emkago Emkago merged commit 841a067 into master Jan 31, 2025
3 checks passed
@Emkago Emkago deleted the 390-fix-threads-parameter-in-medaka branch January 31, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanjameskennedy ryanjameskennedy ryanjameskennedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix threads parameter in medaka
2 participants
@Emkago @ryanjameskennedy