Skip to content

Commit

Permalink
fix silly logic bug in SettingChangedFilter
Browse files Browse the repository at this point in the history
this would ignore the entire condition and just check if the key names matched
  • Loading branch information
matcool authored Dec 29, 2024
1 parent 29b24b5 commit 3665da9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion loader/src/loader/SettingV3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ class SettingChangedFilterV3::Impl final {
ListenerResult SettingChangedFilterV3::handle(std::function<Callback> fn, SettingChangedEventV3* event) {
if (
event->getSetting()->getModID() == m_impl->modID &&
!m_impl->settingKey || event->getSetting()->getKey() == m_impl->settingKey
(!m_impl->settingKey || event->getSetting()->getKey() == m_impl->settingKey)
) {
fn(event->getSetting());
}
Expand Down

0 comments on commit 3665da9

Please sign in to comment.