Fix geo_scope with :through #8
Conversation
…uccessfully under MySQL
…uccessfully under Postgres Add Postgres as a development dependency
…> :some_column by automatically .include'ing the :through option
Also, ActsAsMappable::ClassMethods#geo_scope now returns an instance of
ActsAsMappable::Relation instead of ActiveRelation. Basically, we override
with the distance formula. In other words, if you say
Model.geo_scope(...).where("distance > 5") or
Model.geo_scope(...).order("distance desc"), that "distance" is automatically
replaced with the big long SQL that's generated (the Haversine formula, or
whatever). The downside is that you have to put the .where after the .geo_scope,
otherwise it won't work.
|
I would be great if this could be pulled into the main repo as it fixes a lot of things and has a proper test suite :) |
|
That would make geokit-rails3 really useful! |
|
I tried your branch and am not able to get it to work properly. This is what I did: https://gist.github.com/986323 |
|
Hi, I'm very sorry that I didn't take care of this in a loooong time. According to GitHub, this PR can't be merged automatically, so it needs at least an update. And since it's a quite important improvement, I'd like to have some other confirmation that everything is good. |
|
Okay, no worries. Let me take another look at this and rebase the branch and I'll let you know. |
|
What's the status of this merge? |
|
Thanks for reminding me. I made a new branch that is up to date with master (#26). Give it a shot! |
|
I've found that I need to include .joins(:location) to get the geokit scopes to work on my 'acts_as_mappable :through' models, else I get the 'missing FROM-clause entry for table "locations"' error. My models are all 'belongs_to :location'. Would it be appropriate to add in a conditional join based on the relation type? |
|
@bjornlinder This issue is in the wrong project (I probably should update the readme). Please use geokit-rails (which is for rails3 nowdays). Switching projects may even result in some problems being fixed. Ideally you wouldn't need to do extra joins, but if you have to do something to get it to work I personally think that's fine. It's appropriate if it's the best/only solution. |
|
Ah - sorry about that. Yes, I am using geokit-rails and rails 4.1.5. |
This is a fix for #3. Basically :include is now included automatically for a model that acts_as_mappable :through => :some_column. You'll be happy to know that all the tests pass as well.
It should be noted that this branch is based off the ensure_tests_pass_under_mysql_and_postgres branch I made for #7 (this branch is actually 3 commits and starts at c9172e1). Once you pull that branch in, I'll rebase this.