Change to use glossarist gem #31
Conversation
|
@ronaldtse Tried to run this locally and run into Will try to work on the code based on the test file, but I think to test this completely we will have to wait for the fix. |
|
@HassanAkbar please manually remove this cell and fix other issues. There is no reason to be blocked by it. |
|
@HassanAkbar the issue is resolved. Can you continue? Thanks. |
HassanAkbar
changed the title
|
@ronaldtse this is now ready for review. |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } if lineage_source | ||
| end | ||
|
|
||
| def to_localized_concept_hash |
| value = "superseded" | ||
| when "информация отсутствует" # "information absent"!? | ||
| value = "retired" | ||
| when %w(notValid valid superseded retired) # do nothing |
lib/tc211/termbase/term.rb
Outdated
|
|
||
| attr_accessor *(INPUT_ATTRIBS | OUTPUT_ATTRIBS) | ||
|
|
||
| def initialize(options={}) |
There was a problem hiding this comment.
Method has too many lines. [19/10]
Surrounding space missing in default value assignment.
| release | ||
| ) | ||
|
|
||
| OUTPUT_ATTRIBS = INPUT_ATTRIBS - %i(term alt abbrev synonyms classification) + %i(terms) |
| return @sections if @sections | ||
|
|
||
| @sections = [] | ||
| sections_raw.each_with_index do |x,i| |
| end | ||
| end | ||
|
|
||
| def get_section(x) |
There was a problem hiding this comment.
Method has too many lines. [11/10]
Method parameter must be at least 3 characters long.
|
|
||
| def sections | ||
| return @sections if @sections | ||
| def sections |
There was a problem hiding this comment.
Assignment Branch Condition size for sections is too high. [<5, 16, 5> 17.49/15]
Method has too many lines. [23/10]
| "pol" | ||
| else | ||
| code | ||
| end |
There was a problem hiding this comment.
end at 39, 6 is not aligned with case at 30, 23.
| "dut" | ||
| when "工作语言代码" | ||
| "chn" | ||
| when "pl" |
| @language_code = case code | ||
| when "dut/nld" | ||
| "dut" | ||
| when "工作语言代码" |
| "entry_status" => "valid", | ||
| "review_date" => Time.parse("2013-01-29 00:00:00"), | ||
| "review_decision_date" => Time.parse("2016-10-01 00:00:00"), | ||
| "review_decision_event" => "Publication of ISO 19104:2016" |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
| }, | ||
| { | ||
| "origin" => { | ||
| "ref" => "ISO/TS 19104:2008" |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
| "origin" => { | ||
| "ref" => "ISO 1087-1:2000", | ||
| "clause" => "3.4.9", | ||
| "link" => "https://www.iso.org/standard/20057.html" |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
| ], | ||
| "definition" => [ | ||
| { | ||
| "content" => "designation formed by omitting words or letters from a longer form and designating the same concept" |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
Line is too long. [134/80]
| end | ||
|
|
||
| context "localized_concept count" do | ||
| let(:localized_concepts_count) { Dir.glob("concepts/localized_concept/*").count } |
|
Thank you @HassanAkbar ! |
Fixes #30
This is a WIP. @HassanAkbar can you please help complete this?
The way to reproduce is as follows:
20231214 Multi-Lingual Glossary – Published unlocked with Math.xlsx