Mac build #18
Merged
Mac build #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
commented
Jun 26, 2024
|
@K20shores, making sure I am understanding correctly that your updates to the standalone CMakeLists.txt fix your seg fault issue. True? |
|
@lizziel sorry, I was imprecise with my language. Even with these changes I was seeing the segfault. But that went away when I removed the stack frame limit with |
|
@K20shores, could you update the changelog? |
|
@lizziel done! Sorry for missing that the first time around |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Kyle Shores
Institution: National Center for Atmospheric Research
Describe the update
Adds a github action to build CloudJ on mac with gcc 11, 12, and 13. Some of the cmake files also had to be modified to make it work
Expected changes
There shouldn't be any since there were no code changes. However, when I run the standalone binary, I get a segfault on mac
Reference(s)
None
Related Github Issues and PRs
None