Improve error handling #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Thanks @lizziel for this. I've noted that there are a lot of subroutine calls where we do not trap the RC error code. Otherwise the error won't get passed back to the calling routine and won't eventually reach the main program.
|
Thanks @lizziel! |
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
RC is now passed back to parent model. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
force-pushed
the
feature/error_handling
branch
from
bc0fa37 to
f86d9de
Compare
Signed-off-by: Lizzie Lundgren <[email protected]>
|
This PR resulted in a significant slow-down in GEOS-Chem photolysis in 14.4.2. See #23 for the fix which will be included in GEOS-Chem 14.4.3, and released as Cloud-J 7.7.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR removes the legacy EXITC subroutine which stops the model upon error and replaces it with new subroutine CLOUDJ_ERROR which prints a message and returns RC flag equal to CLDJ_FAILURE. The RC flag is then passed up the calling stack to the parent model for model-specific error handling.
This PR also includes a few no diff structural improvements, including removing redundant instances of implicit none and using "(:)" when assigning all values of an array a constant value.
This update requires updates in all parent models, including GEOS-Chem.
Expected changes
This is a no diff update.
Reference(s)
None
Related Github Issues and PRs
geoschem/geos-chem#2353 (Merge required at the time as this PR)