feature/sectoral_preview_plot #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the preview, also downloads a csv of emissions to be used in IE
msulprizio
reviewed
Jan 28, 2025
src/inversion_scripts/imi_preview.py
Outdated
| @@ -449,7 +453,7 @@ def estimate_averaging_kernel( | |||
|
|
|||
| # use the nudged (prior) emissions for generating averaging kernel estimate | |||
| sf = xr.load_dataset(f"{rundir_path}archive_sf/prior_sf_period{kf_index}.nc") | |||
| prior_ds = get_mean_emissions(startday, endday, prior_cache) | |||
| get_mean_emissions(startday, endday, prior_cache) | |||
There was a problem hiding this comment.
did you mean to delete prior_ds = here?
There was a problem hiding this comment.
Yeah, I'm not entirely sure why this got changed. Good catch! I'll revert this block to the original and retest my code with a KF config.
msulprizio
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both new output files are exported into the existing preview output dir as preview_sectoral_emissions.png and prior_sectoral_statistics.csv.
Tested on Permian case.
