fix: Parse wallet settings from actual settings #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforehand we always used the default wallet settings, which was obviously wrong. I am not a fan of the settings in general, but I left the general design as is as this will anyways get reworked significantly with the architecture revamp.
We don't want to open new jit channels during our architecture revamp. We could have used the `max_allowed_tx_fee_rate_when_opening_channel` to achieve the same goal, but as this was also not working and I already had to touch the code, I figured I am adding an evaluation of the `jit_channels_enabled` which better matches our intentions than the other config.
holzeis
force-pushed
the
fix/wallet-settings
branch
from
d538ee3 to
644f060
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to actually prevent opening new jit channels.