Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Stream methods prefixed with run #1062

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

c0d33ngr
Copy link

Fixes #1047

Problem

Some of the methods in Stream have the run prefix, which was introduced to indicate that the stream will be fully handled and return a computation instead of a Stream instance. Renaming the Stream methods prefixed with run makes it easier to be found

Solution

Rename the Stream methods

Notes

@fwbrasil
Copy link
Collaborator

fwbrasil commented Feb 1, 2025

Thanks for the contribution :) LGTM besides the merge conflicts

@c0d33ngr
Copy link
Author

c0d33ngr commented Feb 1, 2025

Okay. Thank you
I want to also update the documentation too.

@c0d33ngr c0d33ngr marked this pull request as ready for review February 1, 2025 13:06
@c0d33ngr
Copy link
Author

c0d33ngr commented Feb 2, 2025

Oh.. it fails

In my next update, I'll test it against my main branch to avoid worrying you for CI approval. That way I'll know if all it's green

@c0d33ngr c0d33ngr marked this pull request as draft February 2, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Stream.run* methods
2 participants