Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instances count on main menu #6535

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Nov 28, 2024

Closes #6531

Why is this the best possible solution? Were any other approaches considered?

The biggest change I had to make here was to modify InstancesDataServices so that the instances counts were qualified by project. As part of this, I ended up introducing a more formalized way to create/work with data services in the form of a DataService abstract class (in Data.kt).

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The changes made are pretty widespread, so I think a general check of downloading, updating, saving and sending forms would be good here.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg force-pushed the instances-count branch 3 times, most recently from 2620b99 to 4c0bce3 Compare December 5, 2024 11:33
@seadowg seadowg marked this pull request as ready for review January 21, 2025 14:16
@seadowg seadowg requested a review from grzesiek2010 January 21, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant