-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instances count on main menu #6535
Open
seadowg
wants to merge
13
commits into
getodk:master
Choose a base branch
from
seadowg:instances-count
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
force-pushed
the
instances-count
branch
3 times, most recently
from
December 5, 2024 11:33
2620b99
to
4c0bce3
Compare
seadowg
force-pushed
the
instances-count
branch
from
December 11, 2024 13:39
1466411
to
bdd450c
Compare
seadowg
force-pushed
the
instances-count
branch
from
December 20, 2024 14:54
bdd450c
to
d5b2c23
Compare
seadowg
force-pushed
the
instances-count
branch
from
January 21, 2025 09:25
d5b2c23
to
ca7a50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6531
Why is this the best possible solution? Were any other approaches considered?
The biggest change I had to make here was to modify
InstancesDataServices
so that the instances counts were qualified by project. As part of this, I ended up introducing a more formalized way to create/work with data services in the form of aDataService
abstract class (inData.kt
).How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The changes made are pretty widespread, so I think a general check of downloading, updating, saving and sending forms would be good here.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest