Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sveltekit): Insert project config into vite config instead of sentry.properties #378

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 26, 2023

This PR aligns the SvelteKit with the NextJS and wizard to insert the project info (org, project, url) into the bundler config directly, instead of the outdated sentry.properties file.

Doing this now as it's prework to improve our vite config AST modification in a later PR (#362, #363)

closes #291

@Lms24 Lms24 requested review from lforst and AbhiPrasad July 26, 2023 16:17
@Lms24 Lms24 merged commit 0b48979 into master Jul 26, 2023
@Lms24 Lms24 deleted the lms/remove-sentry-properties branch July 26, 2023 16:24
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Insert project config into vite config instead of `sentry.properties` ([#378](https://github.com/getsentry/sentry-wizard/pull/378))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against dc0f44a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sentry.properties generation in favour of setting sentrySvelteKit options
2 participants