ref(sveltekit): Add vite plugin insertion fallback mechanism #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jul 27, 2023
src/sveltekit/sdk-setup.ts
Outdated
|
|
||
| await fs.promises.writeFile(viteConfigPath, code); | ||
| } catch (e) { | ||
| // TODO: log e if --debug is set? |
There was a problem hiding this comment.
Will take care of this in a follow-up PR, as we need to bring the --debug flag into the clack-based wizard options first
AbhiPrasad
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #363 and #362, our automatic vite plugin insertion for
sentrySvelteKitfails when more complex vite config syntax is encountered. We can't reasonably cover these more complex cases but previously we just let the wizard crash, which isn't great either.This PR now adds a fallback mechanism by showing a copy/paste-able snippet with the necessary vite config adjustments, just like we do it in the source maps wizard:
Closes #363
(#362 will be closed in a separate PR)