Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxwidgets: Update to v3.2.6 #4486

Merged
merged 30 commits into from
Dec 30, 2024
Merged

Conversation

androidnisse
Copy link
Contributor

@androidnisse androidnisse commented Nov 29, 2024

Summary

  • Release notes can be found here.

Test Plan

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged (Write an appropriate message in the Summary section)

@androidnisse androidnisse changed the title Update wxwidgets wxwidgets: Update to v3.2.6 Nov 29, 2024
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you add monitoring.yml files to both packages?

EbonJaeger
EbonJaeger previously approved these changes Dec 16, 2024
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if someone wants to merge it. I don't know that I'll get to it today.

@davidjharder
Copy link
Member

Sadly it seems rebuilds might be a good idea, I can't get codelite to build with new wxwidgets

@EbonJaeger EbonJaeger dismissed their stale review December 16, 2024 23:24

Reported revdep failure to build

@davidjharder
Copy link
Member

You have a conflict with cemu because it was updated in the time since this PR was started. You will have a similar issue with audacity. You will need to rebase

@malfisya
Copy link
Member

Missing monitoring.yml in this PR are already included in my PR. Cheers!

@androidnisse
Copy link
Contributor Author

All should be done except KiCad which I have not enough disk space to build.

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Please remove "Summary" from the commit message when no message needed

@malfisya malfisya removed their request for review December 19, 2024 23:27
@malfisya
Copy link
Member

I grep the repo and found 3 packages is still missing from the rebuild:

  • 0ad
  • trelby
  • prusa-slicer

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are ABI removal in radiotray-ng and visualboyadvance-m. Can you make sure both of them run normally?

Also as noted in my previous comment, there are still 3 packages missing from the rebuild:

  • 0ad
  • trelby
  • prusa-slicer

packages/r/radiotray-ng/abi_libs Show resolved Hide resolved
packages/r/radiotray-ng/abi_symbols Show resolved Hide resolved
packages/v/visualboyadvance-m/abi_symbols Show resolved Hide resolved
@androidnisse
Copy link
Contributor Author

There are ABI removal in radiotray-ng and visualboyadvance-m. Can you make sure both of them run normally?

Also as noted in my previous comment, there are still 3 packages missing from the rebuild:

* 0ad

* trelby

* prusa-slicer

0ad and prusa-slicer does not build with current recipe. I have opened two issues for them.

@malfisya malfisya mentioned this pull request Dec 23, 2024
1 task
@EbonJaeger
Copy link
Member

Is this just waiting for 0ad?

@davidjharder
Copy link
Member

davidjharder commented Dec 24, 2024

Not really. Oad doesn't build at the moment, but it's not a wxwidgets issue, as far as i can tell

@androidnisse
Copy link
Contributor Author

Is this just waiting for 0ad?

Not really. Oad doesn't build at the moment, but it's not a wxwidgets issue, as far as i can tell

So can this go in now? :)

@malfisya malfisya added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Dec 29, 2024
androidnisse and others added 15 commits December 30, 2024 20:29
**Summary**

- Added `fz::to_integral_o` that returns an optional
- If `mutex-debugging` is enabled, attempts to destroy a still locked mutex are now detected
- `fz::to_integral` now verifies that the value fits into the return type instead of silently truncating
**Summary**

- Updated translations
- Added option to always refresh remote directory listings when starting a recursive operation
- Changing logfile settings no longer requires a restart of FileZilla
- Fixed a display issue with special characters in usernames
- SFTP: Update interval of transfer progress during uploads should now be more consistent on very slow connections
- Updated to libfilezilla 0.49.0
**Summary**

- This was built using the wxWidgets' v3.2.6 release tag.
- Fix some Python 3.12 compatibility issues (segfault on exit) by upgrading sip & waf
- Fix more float/int conversion issues in `wx.lib` classes
- Add initialValue argument to `wx.lib.DirBrowseButton`
- Fix `wxImage.Clear()`
- Fix blurry text in AuiNotebook tab
- Add support for frozen rows and columns to GridWithLabelRenderersMixin
- demo: ShortcutEditor: Fix broken call GetMenuBar()
- Add proper support for DataViewCheckIconTextRenderer
- Remove legacy macOS logic, use wx.SystemSettings to select colors
- Build: Use new tarfile.extractall() filter for safer tarfile extraction
- Fix typo in wx.lib.agw.persist_handlers0
- Fix 'str' to 'wxString' converstation, when emoji is inside string
- Use unwrap before isbuiltin check
- Preserve pane icons when loading a perspective in agw.aui
- `wx.agw.aui`: don't uninitialize the AuiManager if the window close event is vetoed
- Pure python AUI: Make behavior in all platforms more equal
- `wx.agw.aui`: Do layout as the last step after all pane infos have recomputed their best sizes
- Fix additional SyntaxWarnings with Python 3.12
- Fix `wx.lib.agw.ribbon.RibbonButtonBar` DeleteButton function
- UltimateListCtrl: Add support for `ULC_AUTO_CHECK_PARENT`
- Remove dependency on distutils
- Improve wx.lib.agw.FlatMenu memory usage
- Support NumPy 2.0
- Fix EditLabel on CustomTreeCtrl doesn't automatically select the entire text
- Fix Widgets placed in the UltimateListControl are drawn in the wrong location
- Fix wx.lib.agw.aui sometimes shows "ghost" docking guide
- Fix Thumbnailctrl SetSelection raises exception if it tries to scroll
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am inclined to get this in soon, but why wxPython get updated? Any reason?

@androidnisse
Copy link
Contributor Author

I am inclined to get this in soon, but why wxPython get updated? Any reason?

The version in the repo did not build with this updated version.

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified wxPython update does not affect its revdeps.

@malfisya malfisya merged commit d1cdad3 into getsolus:main Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Sync Notes This PR/Issue can be highlighted in sync notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Please update wxwidgets to 3.2.5 or higher to resolve crash with veracrypt
4 participants