Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readthedocs #110

Merged
merged 11 commits into from
Mar 2, 2021
Merged

Readthedocs #110

merged 11 commits into from
Mar 2, 2021

Conversation

KorayKirli
Copy link
Member

@KorayKirli KorayKirli commented Mar 1, 2021 •
edited
Loading

  • added read the docs
  • added requirements.txt since rtd builds need that. maybe we can shift all requirements here from setup.py
  • added open API support, currently, there are issues with version 3.0, which should be resolved soon.
    Incompatiable with OpenApi 3.0.1 sphinx-contrib/openapi#107
  • formatted filenames titles and subheadings to be user friendly
  • added a placeholder logo

branch build https://datameta.readthedocs.io/en/readthedocs/

KerstenBreuer
KerstenBreuer approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@KerstenBreuer KerstenBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side.

@KerstenBreuer
Copy link
Contributor

KerstenBreuer commented Mar 2, 2021 •
edited
Loading

The logo looks cool 👍 very nice font.
Also very nice that you could configure it to show request and response bodies for the openAPI specs.

lkuchenb
lkuchenb approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@lkuchenb lkuchenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@KorayKirli KorayKirli merged commit bc21976 into main Mar 2, 2021
@lkuchenb lkuchenb deleted the readthedocs branch March 2, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstenBreuer KerstenBreuer KerstenBreuer approved these changes

@lkuchenb lkuchenb lkuchenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KorayKirli @KerstenBreuer @lkuchenb