Handle super+period key combination on macOS
#4564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously on macOS, `super+period` key combination was being blocked in `performKeyEquivalent` due to a control modifier check. This change removes that restriction to allow `super+period` and similar key combinations to be properly handled. Fixes ghostty-org#4540
|
This works but I do have a much more robust solution in the works that solves a bunch of issues at once (since they all stem from similar |
|
Superceded by #4591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
super+periodkey combination was not working properly on macOS.The
performKeyEquivalentmethod in the macOS implementation was restricting key combinations to only those that included the Control modifier. This meant that other valid key combinations likesuper+periodwere being blocked before they could be properly processed.Solution
Removed the Control modifier check in
performKeyEquivalent, allowing other key combinations likesuper+periodto be processed correctly. The key combination is now explicitly handled in the switch statement, which provides better control over which combinations are allowed.demo.mov
Fixes #4540