-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Input Improvements #4591
Merged
+268
−66
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4d103ca
core: add keyEventIsBinding
mitchellh 8b8c53f
macos: add NSEvent extension to convert to libghostty key events
mitchellh 4031815
macos: if a key event would result in an immediate binding then do it
mitchellh 3e89c4c
Key events return boolean if handled
mitchellh 1bcfff3
macos: manual send keyUp event for command key
mitchellh 40bdea7
macos: handle overridden system bindings with no focused window
mitchellh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import Cocoa | ||
| import GhosttyKit | ||
|
|
||
| extension Ghostty { | ||
| /// A comparable event. | ||
| struct ComparableKeyEvent: Equatable { | ||
| let keyCode: UInt16 | ||
| let flags: NSEvent.ModifierFlags | ||
|
|
||
| init(event: NSEvent) { | ||
| self.keyCode = event.keyCode | ||
| self.flags = event.modifierFlags | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import Cocoa | ||
| import GhosttyKit | ||
|
|
||
| extension NSEvent { | ||
| /// Create a Ghostty key event for a given keyboard action. | ||
| func ghosttyKeyEvent(_ action: ghostty_input_action_e) -> ghostty_input_key_s { | ||
| var key_ev = ghostty_input_key_s() | ||
| key_ev.action = action | ||
| key_ev.mods = Ghostty.ghosttyMods(modifierFlags) | ||
| key_ev.keycode = UInt32(keyCode) | ||
| key_ev.text = nil | ||
| key_ev.composing = false | ||
| return key_ev | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I noticed that in this PR, both vim and nvim folders are renamed to "vim" in the Xcode project references. While the final build output still correctly maintains the distinction between vim and nvim folders, I'm curious about the motivation behind this change in the project structure.
I see that both folders contain identical content at the moment, but having two identically named "vim" folders in the Resources group (as shown in the Xcode project navigator) might be a bit confusing for future maintenance. Could you share the reasoning behind this unification of names in the Xcode project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I didn’t do this on purpose at all. So this was somehow a mistake. I’ll take a look!