-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add +boo command #4876
base: main
Are you sure you want to change the base?
cli: add +boo command #4876
Conversation
f16cd47
to
9943f8f
Compare
I thought maybe it was related to my updating of libvaxis (and maybe having multiple |
I also tried using the zig |
I also tried passing the build script the directory of the frames_*.txt and reading them, instead of embedding them in case somehow we were getting artifacts from that. No dice...same binary size. |
Would it make sense to add |
Would it make sense to add `https://github.com/ghostty-org/website` to
`build.zig.zon` and get the frames from there, rather than copying them into
the Ghostty source code? Won't help the binary size but seems "cleaner" to me.
Sounds like a good idea to me.
|
I think this should be totally optional and standalone, and shouldn't be included in the binary |
Please explain why. |
d4b6b33
to
a3a674f
Compare
Add a `+boo` command to show the animation from the website. The data for the frames is compressed during the build process. This build step was added to the SharedDeps object because it is used in both libghostty and in binaries. The compression is done as follows: - All files are concatenated together using \x01 as a combining byte - The files are compressed to a cached build file - A zig file is written to stdout which `@embedFile`s the compressed file and exposes it to the importer - A new anonymous module "framedata" is added in the SharedDeps object Any file can import framedata and access the compressed bytes via `framedata.compressed`. In the `boo` command, we decompress the file and split it into frames for use in the animation. The overall addition to the binary size is 348k.
patches are always something optional you can apply as well |
Add a
+boo
command to show the animation from the website. The datafor the frames is compressed during the build process. This build step
was added to the SharedDeps object because it is used in both
libghostty and in binaries.
The compression is done as follows:
@embedFile
s the compressedfile and exposes it to the importer
Any file can import framedata and access the compressed bytes via
framedata.compressed
. In theboo
command, we decompress the slice andsplit it into frames for use in the animation.
The overall addition to the binary size is 348k.