termio/exec: call waitpid in process exit callback #5353
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4554 xev.Process.wait is documented as being equivalent to calling `waitpid`, i.e. including reaping the process. On Linux, it does this automatically by using pidfd and the `waitid` syscall. On macOS, it wasn't doing this. This commit updates libxev to include a fix that explicitly calls `waitpid` for kqueue.
mitchellh
force-pushed
the
push-nzltwusqqkls
branch
from
2b3d008 to
9ab2e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4554
When a process exited on its own (we didn't kill it), we were not calling waitpid. This commit adds a waitpid call in the event loop process exit notification.
This happened because when an external exit happened we could call
subprocess.externalExitwhich tells our subprocess manager to NOT kill the process (since its already dead). Unfortunately in this case it means we also didn't call waitpid.